Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stream controllers wait for playlist updates before requesting segments from expired playlists #6855

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

robwalch
Copy link
Collaborator

This PR will...

Avoid requesting expired playlist segments when resuming live playback.

Why is this Pull Request needed?

HLS.js should wait for live (not EVENT) playlists to refresh before loading segments if they have not been updated in enough time for the last segment to be older than three target duration past the start of the playlist.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Resolves #6854

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.6.0 milestone Nov 20, 2024
@robwalch robwalch changed the title Avoid requesting expired playlist segments when resuming live playback Make stream controllers wait for playlist updates before requesting segments from expired playlists Nov 21, 2024
@robwalch robwalch merged commit 42ef766 into master Nov 21, 2024
16 checks passed
@robwalch robwalch deleted the bugfix/live-resume-wait-for-refresh branch November 21, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hls.js going after old ts segments after Stop/Resume.
1 participant