Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add videoCodec field to videoPreference options #6483

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Jun 7, 2024

This PR will...

  • Add videoCodec field to config.videoPreference
  • Improve SDR/HDR initial selection results
    • Don't narrow allowed video-ranges to one that is not available
    • Pick lowest in start tier regardless of "skip candidate" rules as long as "can switch within tolerance" check passes
  • Fix return value for setSubtitleOption and undefined->null type for setAudioOption

Why is this Pull Request needed?

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.6.0 milestone Jun 7, 2024
@robwalch robwalch requested a review from iamboorrito June 7, 2024 00:55
@robwalch robwalch force-pushed the feature/video-codec-preference branch from 9b71874 to eb11903 Compare June 7, 2024 01:35
@robwalch robwalch marked this pull request as ready for review June 7, 2024 17:17
@robwalch robwalch removed the request for review from iamboorrito June 11, 2024 18:38
@robwalch robwalch merged commit e349f03 into master Jun 11, 2024
16 checks passed
@robwalch robwalch deleted the feature/video-codec-preference branch June 11, 2024 18:38
robwalch added a commit that referenced this pull request Jun 12, 2024
Fixes regression in dev introduced in #6483 where variant with alternate codec can be selected
@robwalch robwalch mentioned this pull request Jun 12, 2024
3 tasks
robwalch added a commit that referenced this pull request Jun 12, 2024
Fixes regression in dev introduced in #6483 where variant with alternate codec can be selected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant