Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event.ERROR is undefined if don't import Event object. #1755

Merged
merged 1 commit into from
Jun 5, 2018
Merged

Event.ERROR is undefined if don't import Event object. #1755

merged 1 commit into from
Jun 5, 2018

Conversation

oldmtn
Copy link
Contributor

@oldmtn oldmtn commented Jun 5, 2018

This PR will...

Why is this Pull Request needed?

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • no commits have been done in dist folder (we will take care of updating it)
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@tchakabam
Copy link
Collaborator

Ha! :)

This should been detected by the linter. Weird.

@tchakabam tchakabam self-requested a review June 5, 2018 10:56
@tchakabam
Copy link
Collaborator

So. Eslint thinks this is a browser DOM event as one of W3C EventTarget ... :)

We need to get rid of that env browser flag and take things from window explicitly. It's just too risky to operate like so.

@tchakabam
Copy link
Collaborator

by the way, the same problem is in decryptor.js :)

@oldmtn will push a patch and you can merge that into this branch

@tchakabam
Copy link
Collaborator

@oldmtn Hey, thanks for the contribution, I made a more general fix here that addresses the root problem and not only this specific case: #1756

@tchakabam tchakabam merged commit 9805836 into video-dev:master Jun 5, 2018
tchakabam added a commit that referenced this pull request Jun 5, 2018
@oldmtn
Copy link
Contributor Author

oldmtn commented Jun 6, 2018

You are welcome!:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants