Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double import of Font Awesome #286

Merged
merged 13 commits into from
Feb 17, 2021
Merged

Conversation

MyGiHu
Copy link
Contributor

@MyGiHu MyGiHu commented Feb 15, 2021

No description provided.

@victoriadrake
Copy link
Owner

Is the double import in this file? I don't see it. Would you please add a comment to expain?

@MyGiHu
Copy link
Contributor Author

MyGiHu commented Feb 16, 2021

The double import of Font Awesome happens through two files. "style.sass" and "_fonts.sass".

"style.sass" imports "_fonts.sass" which contains a command to import Font Awesome. A few lines later "style.sass" imports Font Awesome again. One import should be sufficient and reduzes the file size of the to creating theme css file.

Note: Font Awesome is imported multiple times by "style.sass" for creating a dark and light (auto option) or user selected style theme. This is not topic of this pull request.

Simplified example:
style.sass:
@import "fonts"
@import "fontawesome-import"

_fonts.sass:
@import "fontawesome-import"

I removed the redundant import command in "_fonts.sass" because "style.sass" contains a neat arranged import list.

@victoriadrake victoriadrake merged commit 31f1499 into victoriadrake:master Feb 17, 2021
@victoriadrake
Copy link
Owner

Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants