-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove double import of Font Awesome #286
Conversation
Adding the "auto" option of themeStyle to the comment.
This reverts commit 913d0f3.
Is the double import in this file? I don't see it. Would you please add a comment to expain? |
The double import of Font Awesome happens through two files. "style.sass" and "_fonts.sass". "style.sass" imports "_fonts.sass" which contains a command to import Font Awesome. A few lines later "style.sass" imports Font Awesome again. One import should be sufficient and reduzes the file size of the to creating theme css file. Note: Font Awesome is imported multiple times by "style.sass" for creating a dark and light (auto option) or user selected style theme. This is not topic of this pull request. Simplified example: _fonts.sass: I removed the redundant import command in "_fonts.sass" because "style.sass" contains a neat arranged import list. |
Thank you again! |
No description provided.