Save all available forecast data, including today's #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Latest commit (2151707) makes parsing of forecast more robust, which is required by this change. |
|
I like this. Having the forecast of the current day is useful. |
|
I'm thinking about merging this but I want to avoid breaking change. Is it possible to rebase on current master branch and add a variable in the |
pguyot
force-pushed
the
save-forecast-data-for-all-available-days
branch
from
2151707
to
b6d3a57
Compare
|
Thank you for your feedback. The branch was rebased and a new parameter was added for the new API behavior. Tests were updated accordingly and a new test even checks the old API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following issue #2, this PR saves all available forecast data, including today's. Today's forecast is returned in
data['forecast'][0], tomorrow's indata['forecast'][1]and so on.