-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styling must not belong to JavaScript #33
Labels
Comments
@slavafomin Agreed. |
+1 |
I'll be submitting a pull request for this later. It seems to be as simple as removing the hard coded css values in the provider in order for overriding the css to actually work. The |
dasois
added a commit
that referenced
this issue
Jul 24, 2014
dasois
added a commit
that referenced
this issue
Jul 24, 2014
Revert "Removed hard coded styling. #33"
Yeah, a solution where styles isn't hardcoded but still possible to change color via JavaScript would be acceptable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Presentation must be separate from business logic.
I suggest to deprecate methods like
height
andcolor
and replace them with CSS styling completely.Right now I can't use my SCSS styles and variables to style progress bar and this is really wrong.
The text was updated successfully, but these errors were encountered: