Populate enum/const from Jakarta AssertTrue and/or AssertFalse annotations #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nephery
force-pushed
the
add-jakarta-assertTrueFalse
branch
from
c50ff1a to
eeaf37a
Compare
Nephery
force-pushed
the
add-jakarta-assertTrueFalse
branch
from
eeaf37a to
00b9426
Compare
There was a problem hiding this comment.
Thank you very much for your excellent contribution.
Just one question about the validity of encountering both @AssertTrue and @AssertFalse simultaneously. If that isn't a relevant scenario for your use case, I'm in favor of removing that.
What do you reckon?
.../src/test/java/com/github/victools/jsonschema/module/jakarta/validation/IntegrationTest.java
Outdated
Show resolved
Hide resolved
...n/java/com/github/victools/jsonschema/module/jakarta/validation/JakartaValidationModule.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Carsten Wickner <[email protected]>
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
...n/java/com/github/victools/jsonschema/module/jakarta/validation/JakartaValidationModule.java
Show resolved
Hide resolved
CarstenWickner
approved these changes
Jul 13, 2024
CarstenWickner
merged commit 0f42e0b
into
victools:jakarta-assert_true_false
11 checks passed
CarstenWickner
added a commit
that referenced
this pull request
Jul 13, 2024
* feat: Populate enum/const from Jakarta AssertTrue/AssertFalse annotations (#456) * chore(docs): update changelog and bump version number --------- Co-authored-by: Jeffrey D <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
enum/constbased on the presence of Jakarta@AssertTrueand/or@AssertFalse.See #455 (comment) for background info.