Fix Jackson JsonUnwrapped to consider inherited members #435
Conversation
Nephery
changed the title
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene
Nephery
force-pushed
the
fix-jsonunwrapped-inheritance
branch
from
d4e905d to
df7eb37
Compare
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene
|
@CarstenWickner thanks for accepting the PR. By any chance, could we get a new release with the fix? We have some new schemas that depend on this working. 🙂 |
|
Hi @Nephery, I'll do the release tonight. |
|
Release v4.34.0 has been published and will likely take a couple of hours to be fully propagated to the various artifact repositories. |
Members with the
@JsonUnwrappedannotation were being completely dropped when inherited from a super-class or interface.This PR fixes the
@JsonUnwrappedlookup to useResolvedMemberinstead ofRawMemberso that it would now consider inherited members. I added a concrete example of how this should work to theIntegrationTest.