chore: further code health refactoring #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 15 findings(s) ✅
- Affected Hotspots: 2 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
✅ Improving Code Health:
- Code Duplication MethodScope.java
- Complex Conditional FieldScope.java: doFindGetter
- Complex Conditional MemberScope.java: getContainerItemAnnotationConsideringFieldAndGetterIfSupported
- Complex Conditional MethodScope.java: doFindGetterField
- Complex Method SchemaBuilder.java: getReferenceKeys 🔥
- Complex Conditional SchemaBuilder.java: getReferenceKeys 🔥
- Bumpy Road Ahead SchemaBuilder.java: buildDefinitionsAndResolveReferences 🔥
- Bumpy Road Ahead SchemaBuilder.java: getReferenceKeys 🔥
- Complex Conditional TypeContext.java: getTypeParameterFor
- Code Duplication SchemaGenerationContextImpl.java 🔥
- Complex Method SchemaGenerationContextImpl.java: generateObjectDefinition 🔥
- Complex Method SchemaGenerationContextImpl.java: populateMethodSchema 🔥
- Complex Method SchemaGenerationContextImpl.java: populateFieldSchema 🔥
- Complex Method AdditionalPropertiesModule.java: createDefinitionForMemberMap
- Complex Conditional ConstantValueModule.java: extractConstantFieldValue
jsonschema-generator/src/main/java/com/github/victools/jsonschema/generator/FieldScope.java
Show resolved
Hide resolved
jsonschema-generator/src/main/java/com/github/victools/jsonschema/generator/MemberScope.java
Show resolved
Hide resolved
jsonschema-generator/src/main/java/com/github/victools/jsonschema/generator/MethodScope.java
Show resolved
Hide resolved
jsonschema-generator/src/main/java/com/github/victools/jsonschema/generator/TypeContext.java
Show resolved
Hide resolved
...src/main/java/com/github/victools/jsonschema/generator/impl/SchemaGenerationContextImpl.java
Show resolved
Hide resolved
...src/main/java/com/github/victools/jsonschema/generator/impl/SchemaGenerationContextImpl.java
Show resolved
Hide resolved
...src/main/java/com/github/victools/jsonschema/generator/impl/SchemaGenerationContextImpl.java
Show resolved
Hide resolved
...src/main/java/com/github/victools/jsonschema/generator/impl/SchemaGenerationContextImpl.java
Show resolved
Hide resolved
...in/java/com/github/victools/jsonschema/generator/impl/module/AdditionalPropertiesModule.java
Show resolved
Hide resolved
.../src/main/java/com/github/victools/jsonschema/generator/impl/module/ConstantValueModule.java
Show resolved
Hide resolved
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 11 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
✅ Improving Code Health:
- Code Duplication MethodScope.java
- Complex Conditional FieldScope.java: doFindGetter
- Complex Conditional MemberScope.java: getContainerItemAnnotationConsideringFieldAndGetterIfSupported
- Complex Conditional MethodScope.java: doFindGetterField
- Complex Conditional TypeContext.java: getTypeParameterFor
- Code Duplication SchemaGenerationContextImpl.java 🔥
- Complex Method SchemaGenerationContextImpl.java: generateObjectDefinition 🔥
- Complex Method SchemaGenerationContextImpl.java: populateMethodSchema 🔥
- Complex Method SchemaGenerationContextImpl.java: populateFieldSchema 🔥
- Complex Method AdditionalPropertiesModule.java: createDefinitionForMemberMap
- Complex Conditional ConstantValueModule.java: extractConstantFieldValue
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 11 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
✅ Improving Code Health:
- Code Duplication MethodScope.java
- Complex Conditional FieldScope.java: doFindGetter
- Complex Conditional MemberScope.java: getContainerItemAnnotationConsideringFieldAndGetterIfSupported
- Complex Conditional MethodScope.java: doFindGetterField
- Complex Conditional TypeContext.java: getTypeParameterFor
- Code Duplication SchemaGenerationContextImpl.java 🔥
- Complex Method SchemaGenerationContextImpl.java: generateObjectDefinition 🔥
- Complex Method SchemaGenerationContextImpl.java: populateMethodSchema 🔥
- Complex Method SchemaGenerationContextImpl.java: populateFieldSchema 🔥
- Complex Method AdditionalPropertiesModule.java: createDefinitionForMemberMap
- Complex Conditional ConstantValueModule.java: extractConstantFieldValue
jsonschema-generator/src/main/java/com/github/victools/jsonschema/generator/MethodScope.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.