feat: jackson module support @JsonTypeInfo.defaultImpl #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking forward to this feature! |
|
I can trigger it in a few hours. |
|
Release of v4.26.0 including this change is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Jackson module's built-in subtype resolution encounters a
@JsonTypeInfo´ annotation with thedefaultImpl` attribute on it, then that particular subtype is not required to include the designated type property.From a schema point of view, the assumption is, that some other properties will make it distinct from different subtypes, in order to avoid "false positives" (e.g., another subtype where the type property was forgotten). That is then the responsibility of the schema creator.
Resolves #278, where this change was suggested by @eleftherias.