Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unit tests for ValueTupleComparer and ValueTupleEqualityComparer #645

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Source/SuperLinq/UnreachableException.cs
Original file line number Diff line number Diff line change
@@ -1,14 +1,19 @@
// Licensed to the .NET Foundation under one or more agreements.
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

#pragma warning disable IDE0130

#if !NET7_0_OR_GREATER
using System.Diagnostics.CodeAnalysis;
#endif

namespace System.Diagnostics;

#if !NET7_0_OR_GREATER
/// <summary>
/// Exception thrown when the program executes an instruction that was thought to be unreachable.
/// </summary>
[ExcludeFromCodeCoverage]
public sealed class UnreachableException : Exception
{
/// <summary>
Expand Down
1 change: 1 addition & 0 deletions Tests/SuperLinq.Test/SuperLinq.Test.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
<ItemGroup>
<ProjectReference Include="..\..\Source\SuperLinq\SuperLinq.csproj" />
<Compile Include="..\..\Source\SuperLinq\ValueTupleEqualityComparer.cs" Link="ValueTupleEqualityComparer.cs" />
<Compile Include="..\..\Source\SuperLinq\ValueTupleComparer.cs" Link="ValueTupleComparer.cs" />
</ItemGroup>

<ItemGroup>
Expand Down
48 changes: 48 additions & 0 deletions Tests/SuperLinq.Test/ValueTupleComparerTest.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
using System.Diagnostics.CodeAnalysis;

namespace Test;

public class ValueTupleComparerTest
{
private class TestComparer : IComparer<string>
{
public int Compare([AllowNull] string x, [AllowNull] string y)
{
var xLen = x?.Length ?? 0;
var yLen = y?.Length ?? 0;
return xLen.CompareTo(yLen);
}
}

[Fact]
public void ValueTupleComparerShouldCreateWithDefaultComparers()
{
var comparer = ValueTupleComparer.Create<int, int>(null, null);
ValueTuple<int, int> left = new(1, 2);
ValueTuple<int, int> right = new(3, 4);
var result = comparer.Compare(left, right);
Assert.Equal(-1, result);
}

[Fact]
public void ValueTupleComparerShouldCheckSecondItemIfFirstIsZero()
{
var comparer = ValueTupleComparer.Create<int, int>(null, null);
ValueTuple<int, int> left = new(1, 3);
ValueTuple<int, int> right = new(1, 2);
var result = comparer.Compare(left, right);
Assert.Equal(1, result);
}

[Fact]
public void ValueTupleComparerShouldAcceptCustomComparers()
{
TestComparer innerLeftComparer = new();
TestComparer innerRightComparer = new();
var comparer = ValueTupleComparer.Create(innerLeftComparer, innerRightComparer);
ValueTuple<string, string> left = new("123", "1");
ValueTuple<string, string> right = new("123", "123");
var result = comparer.Compare(left, right);
Assert.Equal(-1, result);
}
}
79 changes: 79 additions & 0 deletions Tests/SuperLinq.Test/ValueTupleEqualityComparerTest.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
using System.Diagnostics.CodeAnalysis;

namespace Test;

public class ValueTupleEqualityComparerTest
{
private record TestObject(string Value);
private class TestComparer<T>(Func<T?, T?, bool> comparer) : IEqualityComparer<T>
{
public bool Equals(T? x, T? y) => comparer(x, y);
public int GetHashCode([DisallowNull] T obj) => obj.GetHashCode();
}

[Fact]
public void ValueTupleEqualityComparerWithOneTypeArgShouldCreateWhenNoComparerProvided()
{
var comparer = ValueTupleEqualityComparer.Create<int>(null);
ValueTuple<int> left = new(1);
ValueTuple<int> right = new(1);
var result = comparer.Equals(left, right);
Assert.True(result);
}

[Fact]
public void ValueTupleEqualityComparerWithOneTypeArgShouldGetHashCode()
{
var comparer = ValueTupleEqualityComparer.Create<int?>(null);
ValueTuple<int?> first = new(null);
var firstHashCode = comparer.GetHashCode(first);
Assert.Equal(0, firstHashCode);

ValueTuple<int?> second = new(2);
var secondHashCode = comparer.GetHashCode(second);
Assert.Equal(2.GetHashCode(), secondHashCode);
}

[Fact]
public void ValueTupleEqualityComparerWithOneTypeArgShouldCreateWhenComparerProvided()
{
var innerComparer = new TestComparer<TestObject>((x, y) => x?.Value == y?.Value);
var comparer = ValueTupleEqualityComparer.Create(innerComparer);
ValueTuple<TestObject> left = new(new("testing"));
ValueTuple<TestObject> right = new(new("testing"));
var result = comparer.Equals(left, right);
Assert.True(result);
}

[Fact]
public void ValueTupleEqualityComparerWithTwoTypeArgsShouldCreateWhenNoComparerProvided()
{
var comparer = ValueTupleEqualityComparer.Create<int, int>(null, null);
ValueTuple<int, int> left = new(1, 2);
ValueTuple<int, int> right = new(1, 2);
var result = comparer.Equals(left, right);
Assert.True(result);
}

[Fact]
public void ValueTupleEqualityComparerWithTwoTypeArgsShouldCreateWhenComparerProvided()
{
var innerComparerLeft = new TestComparer<TestObject>((x, y) => x?.Value == y?.Value);
var innerComparerRight = new TestComparer<TestObject>((x, y) => x?.Value == y?.Value);
var comparer = ValueTupleEqualityComparer.Create(innerComparerLeft, innerComparerRight);
ValueTuple<TestObject, TestObject> left = new(new("1"), new("2"));
ValueTuple<TestObject, TestObject> right = new(new("1"), new("2"));
var result = comparer.Equals(left, right);
Assert.True(result);
}

[Fact]
public void ValueTupleEqualityComparerWithTwoTypeArgsShouldGetHashCode()
{
var comparer = ValueTupleEqualityComparer.Create<int, int>(null, null);
ValueTuple<int, int> first = new(1, 2);
var firstHashCode = comparer.GetHashCode(first);
var expectedHashCode = HashCode.Combine(1.GetHashCode(), 2.GetHashCode());
Assert.Equal(expectedHashCode, firstHashCode);
}
}
Loading