Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DensePartialSortBy to use NullKeyDictionary #500

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

viceroypenguin
Copy link
Owner

This PR updates the DensePartialSort(By) operators to properly use NullKeyDictionary<>; the previous version was copied from PartialSort(By), and the modification did not remove the unnecessary int Index tuple key.

Fixes #499

@viceroypenguin viceroypenguin added this to the 6.0.0 milestone Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (2c09912) 92.99% compared to head (b20cd66) 93.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
+ Coverage   92.99%   93.04%   +0.05%     
==========================================
  Files         249      249              
  Lines        8182     8184       +2     
  Branches     1635     1635              
==========================================
+ Hits         7609     7615       +6     
+ Misses        359      356       -3     
+ Partials      214      213       -1     
Files Changed Coverage Δ
Source/SuperLinq.Async/DensePartialSort.cs 94.28% <100.00%> (ø)
Source/SuperLinq/Collections/NullKeyDictionary.cs 100.00% <100.00%> (+16.66%) ⬆️
Source/SuperLinq/DensePartialSort.cs 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viceroypenguin viceroypenguin merged commit 243906a into master Aug 25, 2023
3 checks passed
@viceroypenguin viceroypenguin deleted the nullkey-dictionary branch August 25, 2023 20:34
@viceroypenguin viceroypenguin modified the milestones: 6.0.0, 5.3.0 Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update DensePartialSort to use NullKeyDictionary property
1 participant