Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HasDuplicates operator #430

Merged
merged 14 commits into from
May 19, 2023
Merged

Add HasDuplicates operator #430

merged 14 commits into from
May 19, 2023

Conversation

julienasp
Copy link
Contributor

Introducing HasDuplicates for synchronous and Asynchronous sequences

@n0099
Copy link

n0099 commented May 19, 2023

morelinq/MoreLINQ#1001

viceroypenguin
viceroypenguin reviewed May 19, 2023
View reviewed changes
Copy link
Owner

@viceroypenguin viceroypenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits. Looks good though!

Source/SuperLinq.Async/HasDuplicates.cs Outdated Show resolved Hide resolved
Tests/SuperLinq.Test/HasDuplicatesTest.cs Outdated Show resolved Hide resolved
Tests/SuperLinq.Test/HasDuplicatesTest.cs Outdated Show resolved Hide resolved
Tests/SuperLinq.Test/HasDuplicatesTest.cs Outdated Show resolved Hide resolved
Source/SuperLinq/HasDuplicates.cs Outdated Show resolved Hide resolved
Source/SuperLinq/HasDuplicates.cs Outdated Show resolved Hide resolved
@viceroypenguin viceroypenguin changed the title Julienasp/2023/addhasduplicates Add HasDuplicates operator May 19, 2023
@viceroypenguin viceroypenguin added this to the 5.1.0 milestone May 19, 2023
@codecov
Copy link

codecov bot commented May 19, 2023 •
edited
Loading

Codecov Report

Patch coverage: 95.83% and project coverage change: +0.02 🎉

Comparison is base (4122af6) 88.17% compared to head (88904ea) 88.19%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
+ Coverage   88.17%   88.19%   +0.02%     
==========================================
  Files         242      244       +2     
  Lines        7608     7632      +24     
  Branches     1746     1753       +7     
==========================================
+ Hits         6708     6731      +23     
  Misses        462      462              
- Partials      438      439       +1
Impacted Files Coverage Δ
Source/SuperLinq/HasDuplicates.cs 92.30% <92.30%> (ø)
Source/SuperLinq.Async/HasDuplicates.cs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

viceroypenguin
viceroypenguin reviewed May 19, 2023
View reviewed changes
Source/SuperLinq.Async/HasDuplicates.cs Outdated Show resolved Hide resolved
Tests/SuperLinq.Async.Test/HasDuplicatesTest.cs Outdated Show resolved Hide resolved
Source/SuperLinq/HasDuplicates.cs Outdated Show resolved Hide resolved
@julienasp julienasp requested a review from viceroypenguin May 19, 2023 20:23
@viceroypenguin viceroypenguin merged commit 2649f6d into viceroypenguin:master May 19, 2023
@viceroypenguin
Copy link
Owner

Thanks @julienasp!

@viceroypenguin viceroypenguin mentioned this pull request May 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceroypenguin viceroypenguin viceroypenguin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@julienasp @n0099 @viceroypenguin