Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Equivalent support for IAsyncEnumerable #2

Closed
62 of 91 tasks
Arithmomaniac opened this issue Jun 13, 2022 · 6 comments
Closed
62 of 91 tasks

Equivalent support for IAsyncEnumerable #2

Arithmomaniac opened this issue Jun 13, 2022 · 6 comments
Milestone
4.0.0

Comments

@Arithmomaniac
Copy link
Contributor

Arithmomaniac commented Jun 13, 2022 •
edited by viceroypenguin
Loading

For each current method, add an equivalent method for IAsyncEnumerables.

Progress:
viceroypenguin added a commit that referenced this issue Jun 15, 2022
@viceroypenguin
Architecture for SuperLinq.Async (#2)
54abab0
@viceroypenguin
Copy link
Owner

Released preview of SuperLinq.Async. Nowhere near equivalent yet, but architecture is in place and methods can start moving over.

@viceroypenguin viceroypenguin added this to the 4.0.0 milestone Jun 22, 2022
@viceroypenguin
Copy link
Owner

@Arithmomaniac - You mind taking a look through the latest version of the code and validating? I don't have all of the functions migrated, but I've identified separate issues for the remaining ones. I think the latest upload should be good for prod release of v4.

@Arithmomaniac
Copy link
Contributor Author

Just browsing the directory structure, it looks like you got the right idea. (I didn't do a line-by-line-comparison but see that you copied the tests.)

I'd just add a chart at the root Readme along the lines of the following:

Method SuperLinq SuperLinq.Async
Choose ✔️ ✔️
Shuffle ✔️ ❌

@Arithmomaniac
Copy link
Contributor Author

Also, you might want to backlog using a common generator to generate sync and async versions of the same method, instead of needing to copy the code over.

@viceroypenguin
Copy link
Owner

Thanks for the review! I'll definitely update the readme - good advice!

@viceroypenguin viceroypenguin mentioned this issue Jul 18, 2022
Closed
@viceroypenguin
Copy link
Owner

Done. I think I'll release 4.0.0 tomorrow unless you have any other objections.

Bouke added a commit to Bouke/SuperLinq that referenced this issue Jul 16, 2024
@Bouke
# This is a combination of 2 commits.
22a97ef 
# This is the 1st commit message:

Hide API using Index/Range

The polyfills generated by PolySharp cannot be made public as there will be conflicts with the polyfills generated by others.

# The commit message viceroypenguin#2 will be skipped:

# fixup! Hide API using Index/Range
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
2 participants
@Arithmomaniac @viceroypenguin