-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
Now it's working. I'll update the readme. |
This is definitely cleaner. Appreciate the huge amount of time you've dedicated on improving this framework @bre7 😎 Quick question though, is there anything I'm required to do to get this working once I accept the pull request? Or will it work automatically? |
Only push a new version of the spec (1.2.1?) |
…t itself but the framework.
Now it's working...Forgot to add public to functions 😆 |
@bre7 Hmm it seems like you added support for osx, however UIKit is not available on osx. Upon removing that line, and running -> ChameleonFramework (1.2.1)
- ERROR | [iOS] Returned an unsuccessful exit code. You can use `--verbose` for more information.
- NOTE | [iOS] clang: error: linker command failed with exit code 1 (use -v to see invocation)
[!] ChameleonFramework did not pass validation.
You can use the `--no-clean` option to inspect any Tried messing with it, but couldn't seem to find a solution. Any suggestions? |
Ooops. I'll have a look later :) |
PR in a sec the issue was this line: s.source_files .... Since each subspec already defined the source files there were duplicated symbols |
I know you thought about it (#30) but since it was only one file you didn't add it to the sepc.
I think it's simpler to allow devs to use ChameleonFramework/Swift in their podfiles instead of asking them to download a separate file, etc.
(Thanks Cocoalumberjack for the subspec example)