Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Added Swift subspec #36

Merged
merged 6 commits into from
Jul 9, 2015
Merged

Added Swift subspec #36

merged 6 commits into from
Jul 9, 2015

Conversation

bre7
Copy link
Collaborator

@bre7 bre7 commented Jul 5, 2015

I know you thought about it (#30) but since it was only one file you didn't add it to the sepc.
I think it's simpler to allow devs to use ChameleonFramework/Swift in their podfiles instead of asking them to download a separate file, etc.

(Thanks Cocoalumberjack for the subspec example)

@bre7
Copy link
Collaborator Author

bre7 commented Jul 5, 2015

Now it's working. I'll update the readme.

@vicc
Copy link
Owner

vicc commented Jul 5, 2015

This is definitely cleaner. Appreciate the huge amount of time you've dedicated on improving this framework @bre7 😎 Quick question though, is there anything I'm required to do to get this working once I accept the pull request? Or will it work automatically?

@bre7
Copy link
Collaborator Author

bre7 commented Jul 6, 2015

Only push a new version of the spec (1.2.1?)

@bre7
Copy link
Collaborator Author

bre7 commented Jul 8, 2015

Now it's working...Forgot to add public to functions 😆

vicc pushed a commit that referenced this pull request Jul 9, 2015
@vicc vicc merged commit 848b93c into vicc:master Jul 9, 2015
@vicc
Copy link
Owner

vicc commented Jul 9, 2015

@bre7 Hmm it seems like you added support for osx, however UIKit is not available on osx. Upon removing that line, and running pod lib lint on the pod spec I seem to be getting the following error:

 -> ChameleonFramework (1.2.1)
    - ERROR | [iOS] Returned an unsuccessful exit code. You can use `--verbose` for more information.
    - NOTE  | [iOS]  clang: error: linker command failed with exit code 1 (use -v to see invocation)

[!] ChameleonFramework did not pass validation.
You can use the `--no-clean` option to inspect any

Tried messing with it, but couldn't seem to find a solution. Any suggestions?

@bre7
Copy link
Collaborator Author

bre7 commented Jul 9, 2015

Ooops. I'll have a look later :)

@bre7
Copy link
Collaborator Author

bre7 commented Jul 9, 2015

PR in a sec the issue was this line:

s.source_files ....

Since each subspec already defined the source files there were duplicated symbols

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants