-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added basic SMTP documentation and examples #751
Conversation
Thanks, you are right, documentation is a bit thin there. Two corrections/improvements for the doc comment:
Also, do you think that sending the mail from within a HTTP request handler adds any value to the documentation? It seems to be a bit out of place to me when looking at it from a "neutral" point of view. |
I probably over-did it, I would surely be better to remove the variables altogether.
So the |
Exactly, you could also write some text that would appear before the example. This is a relatively recent feature of DMD/Ddoc (not sure if 2.064 or 2.065) that is now also supported for DDOX. |
Added SMTP unittest as an example Fixed imports and added example explanations Added another import
This should be passing, the logs seem to complain about the Redis test |
The failure looks strange, but your changes indeed look good. I'll merge and correct the documentation comment. |
Added basic SMTP documentation and examples
Thanks !
I must have not understood this, which symbol does it describe? |
The first paragraph of a Ddoc comment (where a paragraph is a set of one or more lines delimited by one or more empty lines) is defined to be the "short summary" for the documented symbol as per the Ddoc specification. It is used by DDOX to populate the overview tables. This first paragraph should be relatively short, around maybe 60 to 120 characters. |
The documentation was a little underwhelming in the SMTP module, and I thought the sendmail example in the examples/ directory was quite unhelpful as a quick reference. So, this change serves its purpose of explaining how to send a basic message through
sendMail
, so that anyone can get his solution up within a couple minutes.