Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #481 #501

Merged
merged 1 commit into from
Feb 7, 2014
Merged

Fix issue #481 #501

merged 1 commit into from
Feb 7, 2014

Conversation

nazriel
Copy link
Contributor

@nazriel nazriel commented Feb 6, 2014

Fix issue #481
Again, I am just starting with vibe.d internals so I am not sure if it is the best approach.
Thanks!

@nazriel
Copy link
Contributor Author

nazriel commented Feb 6, 2014

object.Exception@src/rt/minfo.d(129): Aborting: Cycle detected between modules with ctors/dtors:

vibe.http.client -> vibe.http.auth.basic_auth -> vibe.http.server -> vibe.http.dist -> vibe.http.client

Meh 👎
Lets try another way.

Edit:
Seems to be passing on my computer now.
Lets see what Travis CI will say

@s-ludwig
Copy link
Member

s-ludwig commented Feb 7, 2014

Ah nice, thanks! Too bad that there is this module constructor cycle. I'll merge it like this for now and look into that later. Would be a pity to duplicate the code there...

s-ludwig added a commit that referenced this pull request Feb 7, 2014
@s-ludwig s-ludwig merged commit eb99eb0 into vibe-d:master Feb 7, 2014
@nazriel
Copy link
Contributor Author

nazriel commented Feb 8, 2014

@s-ludwig thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants