[WIP] Mark vibe.crypto.passwordhash as deprecated #2365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilzbach
approved these changes
Sep 9, 2019
|
Hum, why was the module not deprecated ? I agree with removing the functions, but it could break packages with lingering imports. |
I'm not sure, I saw this issue but didn't mention for it. Would it be better to mark the passwordhash module as deprecated and remove all functions in this module? |
Yes |
kubo39
force-pushed
the
remove-passwordhash
branch
from
3bdfd58
to
d23ead6
Compare
kubo39
changed the title
kubo39
commented
Sep 10, 2019
vibe.crypto.passwordhash is not secure and useless(see vibe-d#794), so mark this module as deprecated. And All functions in this module were already marked as deprecated, so remove it.
kubo39
force-pushed
the
remove-passwordhash
branch
from
d23ead6
to
9ef58f1
Compare
kubo39
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated passwordhash module, it's insecure.vibe.crypto.passwordhash is not secure, so mark this as deprecated.
And all functions in this module were already marked as deprecated, so just remove.