Fix #1941 - real fix for the workaround #2274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bothered me so long that I've finally looked into it and found the issue. :)
Problem was that test for
isSafeSerializer
is usingwriteValue
andreadValue
for checking and to pass correctly it requires both to compile.In unittests,
TestSerializer
is used and works both as a serializer and a deserializer, so the test passes ok.But that is not the case for ie
JsonStringSerializer
which has only one of those based on the provided range type.