New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate listenTCP without explictly stating the network interface #2087

Open

wilzbach wants to merge 1 commit into vibe-d:master from wilzbach:deprecate-listenTCP

Member

wilzbach commented Feb 25, 2018

See also: #2081 (comment)

My thoughts

if it's always required, listenTCP("127.0.0.1", 8080, ...) would be nicer to read
maybe listenTCP can support a similar shorthand like listenHTTP does (e.g. listenTCP(":8080") or listenTCP("127.0.0.1:8080")
TCPListenOptions and address seem to overload a bit and options is just an enum (just in case more options are added in the future) so it might make sense to do the change once.


          Deprecate listenTCP without explictly stating the network interface

b38bdea

wilzbach mentioned this pull request

run tests on ephemeral ports #2081

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet