Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve web sockets and add autobahn test suite client #1836

Merged
merged 13 commits into from
Jul 12, 2017
Merged

Improve web sockets and add autobahn test suite client #1836

merged 13 commits into from
Jul 12, 2017

Commits on Jul 12, 2017

  1. Only run travis CI when there is a dub.{json,sdl}

    @Geod24 @s-ludwig
    Geod24 authored and s-ludwig committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    7d509a8 View commit details
    Browse the repository at this point in the history

  2. Add an application to test the client websockets implementation again… 

    …st autobahn

Autobahn (http://autobahn.ws/testsuite) is a comprehensive test suite
of the Websocket specifications.
This test won't be run by default as it requires way too much ressources
to put it into the CI, but can trivially be run manually by anyone wanting
to test the websockets implementation for conformity.
    @Geod24 @s-ludwig
    Geod24 authored and s-ludwig committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    e8de0fd View commit details
    Browse the repository at this point in the history

  3. websocket: Allow const ubyte[] to be sent

    @Geod24 @s-ludwig
    Geod24 authored and s-ludwig committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    d61ce1d View commit details
    Browse the repository at this point in the history

  4. WebSocket: Add annotation to WebSocketException ctor

    @Geod24 @s-ludwig
    Geod24 authored and s-ludwig committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    4bba466 View commit details
    Browse the repository at this point in the history

  5. Websockets: Make debug message a bit more informative

    @Geod24 @s-ludwig
    Geod24 authored and s-ludwig committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    d9a6bea View commit details
    Browse the repository at this point in the history

  6. WebSocket: Add IncomingWebSocketMessage.nextFrame

    @Geod24 @s-ludwig
    Geod24 authored and s-ludwig committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    9735642 View commit details
    Browse the repository at this point in the history

  7. Websocket: Minor style fixes (tabify)

    @Geod24 @s-ludwig
    Geod24 authored and s-ludwig committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    12a2957 View commit details
    Browse the repository at this point in the history

  8. WebSocket: Deprecate default FrameOpcode parameter on send 

    We should not assume what the user is sending, as it varies from one application to another.
The default might as well be binary and would seem more sensible to some.
    @Geod24 @s-ludwig
    Geod24 authored and s-ludwig committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    e7067cc View commit details
    Browse the repository at this point in the history

  9. Websocket: Improve Frame.writeFrame code 

    Reduce the need for additional buffer, opening the way
for more memory improvements, and document what it is
doing.

Also corrects a bug with length == 65536, as it would be cast
to `ushort` which maximum size is 65535.

Finally, fixup documentation and type of FrameOpcode.
    @Geod24 @s-ludwig
    Geod24 authored and s-ludwig committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    7f7aa7d View commit details
    Browse the repository at this point in the history

  10. WebSocket: Improvements to Frame.readFrame 

    Reduce number of static buffers (3 -> 1)
Comment the internals
Only demask when the frame is masked (the previous code didn't yield incorrect data,
but needlessly iterated and assigned data to an array)
Check that the most significant bit of the 8 bytes length is 0.
    @Geod24 @s-ludwig
    Geod24 authored and s-ludwig committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    7be942f View commit details
    Browse the repository at this point in the history

  11. Pull Request #1534: Websockets: Add a client test again the autobahn … 

    …testsuite + improvements
    @Geod24 @s-ludwig
    Geod24 authored and s-ludwig committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    7b128cf View commit details
    Browse the repository at this point in the history

  12. Fixup read() signature.

    @s-ludwig
    s-ludwig committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    56949bf View commit details
    Browse the repository at this point in the history

  13. Fixup for read improvements.

    @s-ludwig
    s-ludwig committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    f8bbddc View commit details
    Browse the repository at this point in the history