Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkBasicAuth function. #1687

Merged
merged 1 commit into from
Feb 21, 2017
Merged

Conversation

s-ludwig
Copy link
Member

Separates the authorization test from authorization enforcement.

Fixes #1449.

Separates the authorization test from auhtorization enforcement.
@s-ludwig
Copy link
Member Author

@denizzzka: Is checkBasicAuth sufficient for your use case, or is more control necessary?

@denizzzka
Copy link
Contributor

@s-ludwig checkBasicAuth exactly what is needed. Thanks!

(I am changed my code with checkBasicAuth, but can't run my integration tests because something changed in vibe.d: #1688.)

@s-ludwig
Copy link
Member Author

Okay, I think it should be safe to still merge this into 0.8.0.

Regarding const/in, I don't want to shut the door for more lazy evaluation and reference counting, which is why the HTTPServerRe* values are always passed in plain form.

@s-ludwig s-ludwig merged commit 1faa9db into master Feb 21, 2017
@s-ludwig s-ludwig deleted the issue1449-basic-auth-separate branch March 24, 2017 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants