Added VibeDataNoOpDispatch version #1526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not break existing code but allows us to define a version VibeDataNoOpDispatch. This prevents the compilation of the opDispatch functions in both Bson and Json.
We are semi-regularly running into issues with people using UFCS on a Json object. Instead of calling the function, it uses opDispatch and more often than not returns Json.undefined. This compiles without a problem and sometimes drives you mad when tests fail and you can't see the (not so) obvious issue.
Considering they are deprecated anyway, this allows a nice way for people to throw away this functionality immediately and make better use of things like UFCS.