fix serialization conditions order #1500
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't get to work custom policy to deserialize enum values as I described in forum.
So I tried to find out why and found there is a bug in current implementation.
Problem is with the static if conditions order where even if the enum policy condition passed, it is not used as it is too far bottom and other condition gets prioritized before intended function.
With this PR it works ok.
Although as I looked on the other conditions, it seems to me, that they are wrong too, ie isCustomSerializable!T, isISOExtStringSerializable!T should probably also go upper. But I did not dig deeper.
Sample code, which works for me is this:
I can't get it to compile with JsonStringSerializer - as mentioned on forum (
Error: template vibe.data.serialization.serializeWithPolicy cannot deduce function from argument types !(JsonStringSerializer, UpperCasePolicy)(Test)
)