Fix #1421: Changed the LogLevel when an uncaught exception to a WebSocket is sent #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an exception is caught handling a websocket connection, a logError should be sent instead with the traceback to aid in debugging the actual problem.
|
Before this gets pulled, issue #1420 is also related to this. Is there any design decision to only spit out the message and not the full traceback when an uncaught error occurs? Uncaught errors should definitively be sent to the logger with the traceback. If you want I can do both of the fixes in the same PR. Let me know. |
|
Going the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an exception is caught when handling a websocket connection, a logError should be sent instead with the traceback to aid in debugging the actual problem.