added support for websocket clients #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 9, 2015 20:41
added ws/wss to the URL package made changes to the Frame struct and Websocket class to allow it to be used as a server and client.
|
The ping/pong messages work properly, kinda missed the debug messages. |
| }); | ||
|
|
||
| auto key = "sec-websocket-accept" in res.headers; | ||
| assert(key, answerKey); |
There was a problem hiding this comment.
You don't want an assert here, rather an enforce.
|
Thanks @Kemonozume, I think this looks good to merge now. I'll also add a basic test project that sends a few messages between the client and server. |
s-ludwig
added a commit
that referenced
this pull request
Dec 2, 2015
added support for websocket clients
s-ludwig
added a commit
that referenced
this pull request
Dec 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added ws/wss to the URL package
made changes to the Frame struct and Websocket class to allow it to be
used as a server and client.