Libasync (linux) - Make sure TCP write ready events always occur #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a pretty bad bug actually, the connection freezes when write blocks. Should be merged urgently. |
|
Tested in production as well |
|
I didn't merge this earlier because I didn't understand why a write operation would depend on a "read ready" event. Do you have any further insights on this? Anyway, this is safe to merge, so I'll include it in the release. |
|
I also have an issue understanding why I was blocking on write and receiving only a read event |
s-ludwig
added a commit
that referenced
this pull request
Oct 29, 2015
Libasync (linux) - Make sure TCP write ready events always occur
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.