Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: fix for email validation. #103

Merged
merged 1 commit into from
Oct 3, 2012
Merged

Request: fix for email validation. #103

merged 1 commit into from
Oct 3, 2012

Conversation

1100110
Copy link
Contributor

@1100110 1100110 commented Oct 2, 2012

I could not get anything to validate previously.

It looks to me like it threw an exception every loop through the foreach.

This is why I simply commented it out. Is there any reason to keep this?

I could not get anything to validate previously.
@1100110
Copy link
Contributor Author

1100110 commented Oct 2, 2012

The web forums sorely need this to be fixed.

I cannot get any of my email addresses to validate on the web forum.

@s-ludwig
Copy link
Member

s-ludwig commented Oct 3, 2012

The main reason why this is still there is just higher level error messages. I'll merge the commented out line for now but can you give one or two examples of non-validating emails? I'd still like to understand what goes wrong there.

s-ludwig added a commit that referenced this pull request Oct 3, 2012
Request: fix for email validation.
@s-ludwig s-ludwig merged commit ddeba3d into vibe-d:master Oct 3, 2012
@1100110
Copy link
Contributor Author

1100110 commented Oct 3, 2012

I didn't mean to shove that out without any warning, Sorry.

The Exception on line 84 throws on my computer for these two email addresses:

[email protected]
[email protected]

To be fair, they are weird addresses, but not exceptionally so.

I'll see if I can track it down and fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants