Fix parsing of hidden comments #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hidden comment from the web site
//-title there is no title
is actually processed as
<//-title>there is no title<///-title>
because there is no whitespace between - and t. Jade treats //-title
as a hidden comment.
This PR fixes the parsing problem. I moved all the comment handling
code into one place, too.
|
Looks good, thanks! |
s-ludwig
added a commit
that referenced
this pull request
Mar 14, 2015
Fix parsing of hidden comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hidden comment from the web site
is actually processed as
because there is no whitespace between - and t. Jade treats //-title
as a hidden comment.
This PR fixes the parsing problem. I moved all the comment handling
code into one place, too.