Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid StreamOutputRange in the WebSocket send implementation #1791

Closed
s-ludwig opened this issue Jun 26, 2017 · 0 comments
Closed

Avoid StreamOutputRange in the WebSocket send implementation #1791

s-ludwig opened this issue Jun 26, 2017 · 0 comments

Comments

@s-ludwig
Copy link
Member

This causes an additional write() call on the underlying connection stream (which could be a TLS stream) for large frame payloads (starting from ~252 bytes). Since OutgoingWebSocketMessage already uses an Appender to accumulate payload data, it could easily reserve a few bytes for the header, so that the full frame could be sent in one go.

Original discussion: https://forum.rejectedsoftware.com/groups/rejectedsoftware.vibed/thread/43534/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant