Fix behavior of a 0 second timer, avoid processing them in a task #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't forget this patch for release, processTimers wasnt being run correctly |
|
Bump |
| return; | ||
| } | ||
| else | ||
| if (m_nextSched != next) |
There was a problem hiding this comment.
This if looks like it's redundant.
|
Bump this too: #1247 |
|
Okay, looks good. Just that I unfortunately missed this before release anyway... It needs a rebase, though (merge conflicts). |
Done |
|
Thanks! |
s-ludwig
added a commit
that referenced
this pull request
Sep 21, 2015
Fix behavior of a 0 second timer, avoid processing them in a task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the immediate return issue in waitForData for 0 second timers, amonst other problems.
I think a negative duration might be better suited for immediate timers, since the 0 second already has defined behavior in some cases, mostly because libevent seems to never set a timer (infinite duration)