Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treat warnings as errors #771

Merged
merged 8 commits into from
Oct 22, 2024
Merged

treat warnings as errors #771

merged 8 commits into from
Oct 22, 2024

Conversation

rcannood
Copy link
Member

@rcannood rcannood commented Sep 25, 2024

Describe your changes

  • RRequirements: Treat warnings as errors when installing R dependencies in Docker engines

Related issue(s)

Closes #770

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New functionality (non-breaking change which adds functionality)
  • Major change (non-breaking change which modifies existing functionality)
  • Minor change (non-breaking change which does not modify existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

Requirements:

  • I have read the CONTRIBUTING doc.
  • I have performed a self-review of my code by checking the "Changed Files" tab.
  • My code follows the code style of this project.

Tests:

  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Documentation:

  • Proposed changes are described in the CHANGELOG.md.
  • I have updated the documentation accordingly.

Test Environment

@Grifs Grifs force-pushed the r-treat-warnings-as-errors branch from e748dbe to df0890f Compare October 22, 2024 07:24
@@ -101,7 +101,7 @@ case class RRequirements(
val prefix = if (warnings_as_errors) "options(warn = 2); " else ""

def runRCode(code: String): String = {
s"""Rscript -e "${prefix}${code.replaceAll("\"", "\\\"")}""""
s"""Rscript -e '${prefix}${code}'"""
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switching to ' instead of " makes sense!

Should we not escape ' in the code?

Suggested change
s"""Rscript -e '${prefix}${code}'"""
s"""Rscript -e '${prefix}${code.replaceAll("'", "'\"'\"'"}'"""

CHANGELOG.md Outdated Show resolved Hide resolved
@Grifs Grifs merged commit b6fcca7 into develop Oct 22, 2024
7 checks passed
@Grifs Grifs deleted the r-treat-warnings-as-errors branch October 22, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants