Always use local variables when storing the options to prevent overri…

[Grifs]

…ding in sub functions

Describe your changes

Use local consistently when executing save=$-; set +e in the bash wrapper.
Essentially, the -e option wasn't being set again.

To give a more clear explanation of what's going on:

function foo2 {
	foo="foo2"
	echo "foo2: $foo"
}

function foo1 {
	local foo="foo1"
	foo2
	echo "foo1: $foo"
}

foo="foo"
foo1
echo "foo: $foo"

results in:

foo2: test2
foo1: test2
test: test

Related issue(s)

Closes #753

Type of Change

• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• New functionality (non-breaking change which adds functionality)
• Major change (non-breaking change which modifies existing functionality)
• Minor change (non-breaking change which does not modify existing functionality)
• Bug fix (non-breaking change which fixes an issue)
• This change requires a documentation update

Checklist

Requirements:

• I have read the CONTRIBUTING doc.
• I have performed a self-review of my code by checking the "Changed Files" tab.
• My code follows the code style of this project.

Tests:

• I have added tests that prove my fix is effective or that my feature works.
• New and existing unit tests pass locally with my changes.

Documentation:

• Proposed changes are described in the CHANGELOG.md.
• I have updated the documentation accordingly.

Test Environment

[rcannood]

Could you

• Add a test
• Add local to all local variables in the bash functions

Not sure how I somehow missed this in the first place

[Grifs]

Could you

• Add a test
• Add local to all local variables in the bash functions

Not sure how I somehow missed this in the first place

yes, yes. working on it.

[rcannood]

minor suggestion, otherwise LGTM!