Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make docker runargs configurable #740

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Conversation

rcannood
Copy link
Member

@rcannood rcannood commented Jul 10, 2024

Describe your changes

MINOR CHANGES

Related issue(s)

Closes #xxxx

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New functionality (non-breaking change which adds functionality)
  • Major change (non-breaking change which modifies existing functionality)
  • Minor change (non-breaking change which does not modify existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

Requirements:

  • I have read the CONTRIBUTING doc.
  • I have performed a self-review of my code by checking the "Changed Files" tab.
  • My code follows the code style of this project.

Tests:

  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Documentation:

  • Proposed changes are described in the CHANGELOG.md.
  • I have updated the documentation accordingly.

Test Environment

@rcannood rcannood changed the base branch from main to develop July 10, 2024 05:03
@rcannood rcannood requested a review from Grifs July 11, 2024 09:48
Copy link
Collaborator

@Grifs Grifs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change, isn't this what you probably meant to do?

src/main/scala/io/viash/runners/ExecutableRunner.scala Outdated Show resolved Hide resolved
@rcannood rcannood requested a review from Grifs July 11, 2024 18:06
@Grifs Grifs merged commit 00449aa into develop Jul 16, 2024
7 checks passed
@Grifs Grifs deleted the make_docker_runargs_configurable branch July 16, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants