Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker_engine #722

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Fix docker_engine #722

merged 2 commits into from
Jun 15, 2024

Conversation

Grifs
Copy link
Collaborator

@Grifs Grifs commented Jun 14, 2024

Describe your changes

Related issue(s)

Closes #xxxx

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New functionality (non-breaking change which adds functionality)
  • Major change (non-breaking change which modifies existing functionality)
  • Minor change (non-breaking change which does not modify existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

Requirements:

  • I have read the CONTRIBUTING doc.
  • I have performed a self-review of my code by checking the "Changed Files" tab.
  • My code follows the code style of this project.

Tests:

  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Documentation:

  • Proposed changes are described in the CHANGELOG.md.
  • I have updated the documentation accordingly.

Test Environment

@Grifs Grifs requested a review from rcannood June 14, 2024 18:35
@Grifs
Copy link
Collaborator Author

Grifs commented Jun 14, 2024

Note: It might look odd in the changes, but there is already a check whether the config and namespace_separator are both Some(...) or None. If we map the config.namespace, we know it isn't None, therefore namespace_separator isn't None either.

@Grifs Grifs merged commit 9da6779 into develop Jun 15, 2024
7 checks passed
@Grifs Grifs deleted the fix/docker_engine_namespace branch June 15, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants