Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/nextflow executable build info #720

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Conversation

Grifs
Copy link
Collaborator

@Grifs Grifs commented Jun 11, 2024

Describe your changes

Decide whether the executable filename is the component name or 'main.nf' based on runner type and not mainScript type

Related issue(s)

Closes #716

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New functionality (non-breaking change which adds functionality)
  • Major change (non-breaking change which modifies existing functionality)
  • Minor change (non-breaking change which does not modify existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

Requirements:

  • I have read the CONTRIBUTING doc.
  • I have performed a self-review of my code by checking the "Changed Files" tab.
  • My code follows the code style of this project.

Tests:

  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Documentation:

  • Proposed changes are described in the CHANGELOG.md.
  • I have updated the documentation accordingly.

Test Environment

Grifs added 2 commits June 11, 2024 11:06
….nf' based on runner type and not mainScript type
Need to set workingDir, create a _viash.yaml file and need to remain in the same folder with the output folder to avoid anonymizing
@Grifs Grifs requested a review from rcannood June 11, 2024 10:34
@Grifs Grifs changed the base branch from main to develop June 11, 2024 10:34
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Grifs Grifs merged commit 3380ff2 into develop Jun 13, 2024
7 checks passed
@Grifs Grifs deleted the fix/nextflow_executable_build_info branch June 13, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] build_info lists wrong executable
2 participants