Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove resources_test again #711

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Remove resources_test again #711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f65bbf
Remove resources_test again
Grifs Jun 4, 2024
21ae981
Add PR #
Grifs Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

TODO add summary

## MINOR CHANGES

* `resources_test`: This field is removed again from the `_viash.yaml` as it was decided to impliment this temporary functionality using the `info` field (PR #711).

# Viash 0.9.0-RC4 (2024-05-29): Improvements for CI

These are mainly improvements for issues highlighted by running Viash in a CI environment.
Expand Down
10 changes: 0 additions & 10 deletions src/main/scala/io/viash/packageConfig/PackageConfig.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,16 +172,6 @@ case class PackageConfig(
@default("Empty")
@since("Viash 0.9.0")
links: Links = Links(),

@description("The resources that are required for testing.")
@example(
"""resources_test:
| - "https://raw.githubusercontent.com/viash-io/viash/main/CHANGELOG.md"
| - "https://www.scala-lang.org/feed/blog.xml"
|""".stripMargin, "yaml")
@default("Empty")
@since("Viash 0.9.0")
resources_test: OneOrMore[String] = Nil,
)

object PackageConfig {
Expand Down
Loading