Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/dependency repositories with name #703

Merged
merged 6 commits into from
May 29, 2024
Merged

Fix/dependency repositories with name #703

merged 6 commits into from
May 29, 2024

Conversation

Grifs
Copy link
Collaborator

@Grifs Grifs commented May 14, 2024 •
edited
Loading

Describe your changes

Don't allow the 'name' field in .dependency.repository in the .config.vsh.yaml.

Related issue(s)

Closes #xxxx

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New functionality (non-breaking change which adds functionality)
  • Major change (non-breaking change which modifies existing functionality)
  • Minor change (non-breaking change which does not modify existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

Requirements:

  • I have read the CONTRIBUTING doc.
  • I have performed a self-review of my code by checking the "Changed Files" tab.
  • My code follows the code style of this project.

Tests:

  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Documentation:

  • Proposed changes are described in the CHANGELOG.md.
  • I have updated the documentation accordingly.

Test Environment

Grifs added 4 commits May 14, 2024 10:26
@Grifs
Rework repositories to have an explicit version without name
89c65b4
@Grifs
Undo most of the class changes to enforce usage of repositories witho…
8c8db45 
…ut name and instead use an assert

While it made the expected class very explicit on the side of dependencies, the inheritance was becoming quite complex
This solution relies on using the correct '.withoutName' call at the right moment(s), the assert assures that it is done correctly
@Grifs
cleanup of some remaining changes
9c448f2
@Grifs
add changelog entry
173cc98
@Grifs Grifs added this to the Viash 0.9.x milestone May 14, 2024
@Grifs Grifs requested a review from rcannood May 14, 2024 09:22
@Grifs Grifs merged commit 0c60e90 into develop May 29, 2024
7 checks passed
@Grifs Grifs deleted the fix/dependency_repositories_with_name branch May 29, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcannood rcannood rcannood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Viash 0.9.x
Development

Successfully merging this pull request may close these issues.
2 participants
@Grifs @rcannood