Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker_id variation when using custom docker registry #679

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

Grifs
Copy link
Collaborator

@Grifs Grifs commented Apr 8, 2024

Describe your changes

Correctly use the custom docker registry settings when building a test script.
Add tests that check build and test steps

Related issue(s)

#678

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New functionality (non-breaking change which adds functionality)
  • Major change (non-breaking change which modifies existing functionality)
  • Minor change (non-breaking change which does not modify existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

Requirements:

  • I have read the CONTRIBUTING doc.
  • I have performed a self-review of my code by checking the "Changed Files" tab.
  • My code follows the code style of this project.

Tests:

  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Documentation:

  • Proposed changes are described in the CHANGELOG.md.
  • I have updated the documentation accordingly.

Test Environment

Add tests to verify the docker id in build and test
CHANGELOG.md Outdated Show resolved Hide resolved
@Grifs Grifs requested a review from rcannood April 8, 2024 13:07
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion

CHANGELOG.md Outdated Show resolved Hide resolved
@Grifs Grifs merged commit ccc11d3 into develop Apr 17, 2024
7 checks passed
@Grifs Grifs deleted the fix/tests_docker_id branch April 17, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants