-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/resolved paths in config view #668
Conversation
Before writing config to file during build, set `path` to `resolvedPath` (not when `text` is defined though. Big Badda boom)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #668 +/- ##
===========================================
+ Coverage 92.49% 92.58% +0.09%
===========================================
Files 127 127
Lines 3903 3913 +10
Branches 629 630 +1
===========================================
+ Hits 3610 3623 +13
+ Misses 293 290 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this! It's great that this issue was resolved before 0.9.0 gets released.
Would it be possible to add a test that checks whether the path makes sense when running viash config view
and after running viash build
? 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM!
Describe your changes
Don't change
path
while reading the config's resources.Add
resolvedPath
method to implement the previous function.All
path
use is replaced withresolvedPath
.Update
path
just before writing it to file during aviash [ns] build
Related issue(s)
Closes #654
Type of Change
Checklist
Requirements:
Tests:
Documentation:
Test Environment