Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/resolved paths in config view #668

Merged
merged 8 commits into from
Apr 2, 2024

Conversation

Grifs
Copy link
Collaborator

@Grifs Grifs commented Mar 29, 2024

Describe your changes

Don't change path while reading the config's resources.
Add resolvedPath method to implement the previous function.
All path use is replaced with resolvedPath.
Update path just before writing it to file during a viash [ns] build

Related issue(s)

Closes #654

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New functionality (non-breaking change which adds functionality)
  • Major change (non-breaking change which modifies existing functionality)
  • Minor change (non-breaking change which does not modify existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

Requirements:

  • I have read the CONTRIBUTING doc.
  • I have performed a self-review of my code by checking the "Changed Files" tab.
  • My code follows the code style of this project.

Tests:

  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Documentation:

  • Proposed changes are described in the CHANGELOG.md.
  • I have updated the documentation accordingly.

Test Environment

Grifs added 4 commits March 29, 2024 11:36
Before writing config to file during build, set `path` to `resolvedPath` (not when `text` is defined though. Big Badda boom)
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.58%. Comparing base (9b251dd) to head (bb5e4c2).

Files Patch % Lines
...ain/scala/io/viash/config/resources/Resource.scala 92.85% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #668      +/-   ##
===========================================
+ Coverage    92.49%   92.58%   +0.09%     
===========================================
  Files          127      127              
  Lines         3903     3913      +10     
  Branches       629      630       +1     
===========================================
+ Hits          3610     3623      +13     
+ Misses         293      290       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Grifs Grifs requested a review from rcannood March 29, 2024 12:46
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! It's great that this issue was resolved before 0.9.0 gets released.

Would it be possible to add a test that checks whether the path makes sense when running viash config view and after running viash build? 😬

@Grifs Grifs requested a review from rcannood April 2, 2024 09:00
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@rcannood rcannood merged commit 15db864 into develop Apr 2, 2024
9 checks passed
@rcannood rcannood deleted the fix/resolved_paths_in_config_view branch April 2, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants