Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change multiple_sep from : to ; #645

Merged
merged 7 commits into from
Feb 12, 2024
Merged

Change multiple_sep from : to ; #645

merged 7 commits into from
Feb 12, 2024

Conversation

rcannood
Copy link
Member

@rcannood rcannood commented Feb 11, 2024

Describe your changes

  • Change default multiple_sep from : to ; to avoid conflicts with paths like s3://foo/bar.

Related issue(s)

Closes #xxxx

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New functionality (non-breaking change which adds functionality)
  • Major change (non-breaking change which modifies existing functionality)
  • Minor change (non-breaking change which does not modify existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

Requirements:

  • I have read the CONTRIBUTING doc.
  • I have performed a self-review of my code by checking the "Changed Files" tab.
  • My code follows the code style of this project.

Tests:

  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Documentation:

  • Proposed changes are described in the CHANGELOG.md.
  • I have updated the documentation accordingly.

Test Environment

Copy link
Collaborator

@Grifs Grifs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to define a const somewhere and refer to that value in e.g. the nextflow script methods?

Additionally, we can perhaps set the @default(";") annotation in the abstract class Argument and let the arguments inherit the setting. TBC that it actually works.

@rcannood
Copy link
Member Author

Would it make sense to define a const somewhere and refer to that value in e.g. the nextflow script methods?

Additionally, we can perhaps set the @default(";") annotation in the abstract class Argument and let the arguments inherit the setting. TBC that it actually works.

Good point!

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c7a676) 92.48% compared to head (5cf8810) 92.48%.
Report is 3 commits behind head on develop.

❗ Current head 5cf8810 differs from pull request most recent head 79ee78b. Consider uploading reports for the commit 79ee78b to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #645   +/-   ##
========================================
  Coverage    92.48%   92.48%           
========================================
  Files          129      129           
  Lines         3883     3883           
  Branches       644      644           
========================================
  Hits          3591     3591           
  Misses         292      292           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Grifs Grifs force-pushed the change_multiple_sep branch from 447b6a1 to 5cf8810 Compare February 12, 2024 14:51
@Grifs
Copy link
Collaborator

Grifs commented Feb 12, 2024

This PR looks fine to me now

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Hendrik Cannoodt <[email protected]>
@Grifs Grifs merged commit cb198b0 into develop Feb 12, 2024
7 checks passed
@Grifs Grifs deleted the change_multiple_sep branch February 12, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants