-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change multiple_sep from :
to ;
#645
Conversation
… paths like `s3://foo/bar`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to define a const
somewhere and refer to that value in e.g. the nextflow script methods?
Additionally, we can perhaps set the @default(";")
annotation in the abstract class Argument
and let the arguments inherit the setting. TBC that it actually works.
src/main/scala/io/viash/functionality/arguments/DoubleArgument.scala
Outdated
Show resolved
Hide resolved
src/main/scala/io/viash/functionality/arguments/FileArgument.scala
Outdated
Show resolved
Hide resolved
src/main/scala/io/viash/functionality/arguments/IntegerArgument.scala
Outdated
Show resolved
Hide resolved
src/main/scala/io/viash/functionality/arguments/LongArgument.scala
Outdated
Show resolved
Hide resolved
src/main/scala/io/viash/functionality/arguments/StringArgument.scala
Outdated
Show resolved
Hide resolved
Good point! |
Co-authored-by: Hendrik Cannoodt <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #645 +/- ##
========================================
Coverage 92.48% 92.48%
========================================
Files 129 129
Lines 3883 3883
Branches 644 644
========================================
Hits 3591 3591
Misses 292 292 ☔ View full report in Codecov by Sentry. |
447b6a1
to
5cf8810
Compare
This PR looks fine to me now |
Co-authored-by: Hendrik Cannoodt <[email protected]>
Describe your changes
multiple_sep
from:
to;
to avoid conflicts with paths likes3://foo/bar
.Related issue(s)
Closes #xxxx
Type of Change
Checklist
Requirements:
Tests:
Documentation:
Test Environment