-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge arguments into argument_groups in preparse step #574
Conversation
Codecov ReportAttention:
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
The functionality was removed in Viash 0.7.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a scary set of changes, but I guess it's okay since all the tests pass!
Optionally we could rename allArguments
to simply arguments
, since arguments
has no other function other than provide documentation. WDYT?
I guess that should be fine. There is a certain risk that it's a bit obfuscated that the Edit: I believe tying the documentation of |
Arguably the same could be said about the argument groups itself :p |
Describe your changes
Merge arguments into argument_groups in preparse step
Issue ticket number and link
Closes #573
Checklist before requesting a review
I have performed a self-review of my code
Does this PR contain:
Proposed changes are described in the CHANGELOG.md
Relevant unit tests have been added