Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config inject: Doesn't work when must_exist == true (#273). #274

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

rcannood
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 85.56% // Head: 85.54% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (3a16a71) compared to base (46df237).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #274      +/-   ##
===========================================
- Coverage    85.56%   85.54%   -0.02%     
===========================================
  Files           84       84              
  Lines         2979     2982       +3     
  Branches       182      177       -5     
===========================================
+ Hits          2549     2551       +2     
- Misses         430      431       +1     
Impacted Files Coverage Δ
.../main/scala/io/viash/platforms/DebugPlatform.scala 89.47% <66.66%> (-1.96%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rcannood rcannood merged commit 3b50337 into develop Oct 26, 2022
@rcannood rcannood deleted the fix/issue_273 branch October 27, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant