Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change notices when pulling/building docker containers #94

Closed
rcannood opened this issue Dec 8, 2021 · 2 comments
Closed

Change notices when pulling/building docker containers #94

rcannood opened this issue Dec 8, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@rcannood
Copy link
Member

rcannood commented Dec 8, 2021

Our current output messages might scare off first time users:

$ wget -qO- get.viash.io | bash
[notice] Running 'docker pull viash_viash_install:0.1'
Error response from daemon: pull access denied for viash_viash_install, repository does not exist or may require 'docker login': denied: requested access to the resource is denied
[notice] Running 'docker build -t viash_viash_install:0.1 /tmp/viashsetupdocker-viash_install-1YUosC'

it might be helpful to change the notice to catch that and report something like "checking if docker container is available at XXX" and then "Container not found, building from scratch".

Thanks @dburkhardt for the suggestion!

@rcannood rcannood self-assigned this Dec 8, 2021
@rcannood rcannood added the enhancement New feature or request label Dec 8, 2021
@BlackDragonBE
Copy link
Contributor

@rcannood
I'm all for user friendliness!

Along the same vein of thought, maybe it might be sensible to check if docker is installed at the start of the script? Currently it throws a bunch of bash: line xxx: docker: command not found errors if docker isn't installed.
The script could notify the user with a friendly message like "Docker wasn't found on your system. Please see this page for instructions: https://docs.docker.com/get-docker" for example.

rcannood added a commit that referenced this issue Feb 3, 2022
@rcannood rcannood mentioned this issue Feb 3, 2022
@rcannood
Copy link
Member Author

rcannood commented Feb 3, 2022

Should be implemented in Viash 0.5.6!

@BlackDragonBE: For unrelated issues or semi-related issues, please create a separate issue next time ;)

@rcannood rcannood closed this as completed Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants