Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate auto-detected mounts #257

Closed
rcannood opened this issue Oct 17, 2022 · 1 comment
Closed

Remove duplicate auto-detected mounts #257

rcannood opened this issue Oct 17, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@rcannood
Copy link
Member

Viash executable pass duplicate mounts to Docker. For example, with the following component:

functionality:
  name: foo
  arguments:
    - name: "--input"
      type: file
      multiple: true
  resources:
    - type: python_script
      path: script.py
      text: print(par)
platforms:
  - type: docker
    image: python:3.10

Running bin/foo --input one --input one will cause the generated docker command to be:

docker run --entrypoint=bash -i --rm \
  -v "/foo/test:/viash_automount/foo/test" \
  -v "/foo/test:/viash_automount/foo/test" \
  -v "/foo/test/bin:/viash_automount/foo/test/bin" \
  -v "/foo/test/bin:/viash_automount/foo/test/bin" \
  -v "/foo/workspace/viash_temp:/viash_automount/foo/workspace/viash_temp" \
  foo:latest

Duplicate mounts (even if they are exactly the same) will result in an error being thrown by podman.

rcannood added a commit that referenced this issue Oct 17, 2022
`DockerPlatform`: Remove duplicate auto-mounts (#257).
@rcannood
Copy link
Member Author

Solved with #258

@rcannood rcannood added the bug Something isn't working label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant