Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-4089: change camera api return types #495

Conversation

purplenicole730
Copy link
Member

@purplenicole730 purplenicole730 commented Dec 4, 2023

Return ViamImage object when using camera component.

Tested using laptop's webcam!
mycam get_image return value: <viam.media.video.ViamImage object at 0x102f3de10>
tmp4wghpj1b

Copy link
Contributor

github-actions bot commented Dec 4, 2023

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base is_moving
board gpio_pin_by_name
camera get_image
encoder get_position
motor is_moving
sensor get_readings
servo get_position
arm get_end_position
gantry get_lengths
gripper is_moving
movement_sensor get_linear_acceleration
input_controller get_controls
audio get_properties
pose_tracker get_poses
power_sensor get_power
motion get_pose
vision get_classifications_from_camera

@purplenicole730 purplenicole730 marked this pull request as ready for review December 4, 2023 22:28
@purplenicole730 purplenicole730 requested a review from a team as a code owner December 4, 2023 22:28
@benjirewis benjirewis removed their request for review December 5, 2023 23:54
@benjirewis
Copy link
Member

Hmm this seems good to me, but I worry I don't have enough context to review here. Will bring up in weekly sync whether Maxim and I should continue to be in the sdk-netcode group (and whether that should be renamed).

@purplenicole730
Copy link
Member Author

@bazile-clyde Could someone from your team also provide a PR so that we're certain we're doing everything correctly?

@bazile-clyde
Copy link

@bazile-clyde Could someone from your team also provide a PR so that we're certain we're doing everything correctly?

Provide a PR for what exactly? Are you asking us to review this PR, or create our own PR for something?

@purplenicole730
Copy link
Member Author

@bazile-clyde Could someone from your team also provide a PR so that we're certain we're doing everything correctly?

Provide a PR for what exactly? Are you asking us to review this PR, or create our own PR for something?

Oh oops, sorry about that! I meant review this PR 😅

@bazile-clyde
Copy link

@bazile-clyde Could someone from your team also provide a PR so that we're certain we're doing everything correctly?

Provide a PR for what exactly? Are you asking us to review this PR, or create our own PR for something?

Oh oops, sorry about that! I meant review this PR 😅

No worries! I can review it. Adding myself now.

@bazile-clyde bazile-clyde self-requested a review December 7, 2023 17:23
Copy link

@bazile-clyde bazile-clyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@njooma njooma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@purplenicole730 purplenicole730 merged commit 35c64cb into viamrobotics:main Dec 8, 2023
12 checks passed
@purplenicole730 purplenicole730 deleted the RSDK-4089-change-camera-api-return-types branch December 11, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants