-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSDK-4089: change camera api return types #495
RSDK-4089: change camera api return types #495
Conversation
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
Hmm this seems good to me, but I worry I don't have enough context to review here. Will bring up in weekly sync whether Maxim and I should continue to be in the |
@bazile-clyde Could someone from your team also provide a PR so that we're certain we're doing everything correctly? |
Provide a PR for what exactly? Are you asking us to review this PR, or create our own PR for something? |
Oh oops, sorry about that! I meant review this PR 😅 |
No worries! I can review it. Adding myself now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Return ViamImage object when using camera component.
Tested using laptop's webcam!
mycam get_image return value: <viam.media.video.ViamImage object at 0x102f3de10>