[DATA-2034] Add file extensions to binary data capture upload #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyrhyde
reviewed
Oct 17, 2023
| @@ -437,6 +437,7 @@ async def binary_data_capture_upload( | |||
| method_parameters: Optional[Mapping[str, Any]] = None, | |||
| tags: Optional[List[str]] = None, | |||
| data_request_times: Optional[Tuple[datetime, datetime]] = None, | |||
| file_extension: Optional[str] = None, | |||
There was a problem hiding this comment.
Can/does the file extension get translated to mime_type in the cloud?
agreenb
approved these changes
Oct 17, 2023
| @@ -437,6 +437,7 @@ async def binary_data_capture_upload( | |||
| method_parameters: Optional[Mapping[str, Any]] = None, | |||
| tags: Optional[List[str]] = None, | |||
| data_request_times: Optional[Tuple[datetime, datetime]] = None, | |||
| file_extension: Optional[str] = None, | |||
agreenb
reviewed
Oct 17, 2023
src/viam/app/data_client.py
Outdated
| @@ -453,6 +454,7 @@ async def binary_data_capture_upload( | |||
| tags (Optional[List[str]]): Optional list of tags to allow for tag-based data filtering when retrieving data. | |||
| data_request_times (Optional[Tuple[datetime.datetime, datetime.datetime]]): Optional tuple containing `datetime`s objects | |||
| denoting the times this data was requested[0] by the robot and received[1] from the appropriate sensor. | |||
| file_extension (str): The file extension of binary data including the period, e.g. .jpg, .png, .pcd | |||
There was a problem hiding this comment.
Could you include that this routes the file to its corresponding mime type in the backend?
There was a problem hiding this comment.
@agreenb how's this for text:
The backend will route the binary to its corresponding mime type based on this extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to provide file_extension to binary data capture upload