-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSDK-5109 - add close function #458
RSDK-5109 - add close function #458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks pretty good! can you update the docs/example modules to refer to this new functionality as well? In the example modules, I think just logging something will be good, just want to surface the function within the examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good pending updates from @cheukt's comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few smaller nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jira ticket
Add a
close()
function to the Python SDK so that users can specify what happens when a resource closes. This function is not meant to be called directly, but rather to be called when a module or resource manager is removing a resource.Changes
ResourceBase
that returns nothing, but can be overwrittenclose()
when removing a resourceclose()
functions were called appropriatelyclose()
function, where it calls all its resources'close()
functionsClosing the resource manager was also tested manually by printing out statements in the example's
server.py