RSDK-8469 - Fix offline dial #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
force-pushed
the
fix-offline-dial
branch
from
998bf2f
to
2ca1421
Compare
purplenicole730
approved these changes
Aug 14, 2024
|
LGTM from me too, maybe worth waiting for it to land in the mainline release? I'm seeing that your PR was merged yesterday |
Yeah I'm gonna update to point to that commit in their github repo, but probably won't wait until they do an actual release (those tend to be pretty infrequent and I'd like to get this out sooner rather than later). We can always update to point to the official release once it goes out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for loopback candidates in webRTC, allowing us to establish webRTC connections via mDNS in offline scenarios. Previously, offline connectivity only worked via gRPC in rust-utils.
Note that this relies on fixes to the upstream
webrtc-rscrate which have not yet been merged. As such, we have to point to my branch of thewebrtccrate inCargo.toml. It might be good to consider whether we merge this to a separate branch thanmain, or hold off on merging until upstream fixes are merged. Either way, it seemed good to have this up at least so people can look and use as necessary.The upstream fix, if anyone cares to see, is located at webrtc-rs/webrtc#603