RSDK-7422 - Upgrade webrtc past 0.9.0 to avoid/fix dtls cbc padding #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaniels
changed the title
|
Glad it's a simple fix at least! Thanks for digging/finding this :) |
stuqdog
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, this includes the fix from webrtc-rs/webrtc@4e09f92 which really reverts webrtc-rs/webrtc@935283a (broken at 0.9.0->latest_tag). To be honest, I'm not sure how the original commit was accepted without any questions about why the padding was changed (left a comment on webrtc-rs/webrtc#557 (comment) asking why).
Confirmed this fixes connectivity to an ESP32.
Note for future maintainer: upgrading any further to webrtc-rs/webrtc@49140ea will have dependency constraints fail on `sublte.